Conversation
georgefst
requested review from
fendor,
michaelpj and
santiweight
as code owners
georgefst
force-pushed
the
splice-plugin-9.14
branch
from
2f1b405 to
2ca6b74
Compare
Collaborator
Author
|
This should be ready for review now. @fendor? |
georgefst
force-pushed
the
splice-plugin-9.14
branch
from
2ca6b74 to
cfc780a
Compare
fendor
approved these changes
May 5, 2026
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
LGTM, thank you! You still seem to need to fix -Werror, which is what the stackage builds are about.
Comment on lines
+421
to
+425
| #if MIN_VERSION_ghc(9,13,0) | ||
| , diagHints = [] | ||
| #else | ||
| , diagHints = Error.diagnosticHints message | ||
| #endif |
Collaborator
There was a problem hiding this comment.
Why do we do this? Afaict, diagnosticHints do exist for GHC 9.14 as well. Are they no longer needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4829.
LLM usage disclaimer
Claude Opus 4.6 was used for:
Actual code changes are minimal and artisanally hand-written.